Add custom headers support to the STOMP CONNECT frame

Hello, I need to send additional data in the connect frame (device-id and token). It is not stated forbidden (nor allowed) in the stomp protocol documentation, but unfortunately some servers are expecting values here. I see you do not allow custom header for that frame, is that intentional, or maybe you didn’t have the use case yet ?

If you accept, i can do a PR to edit WebSocketSession.stompConnectand StompClient.connect functions.

Additionally, THANK YOU for such a great work on this modern library.

[Mostrapotski]

I work for a French retailer (red branding, I believe you can guess who it is!)

When entering the store, you can scan a loyalty card on a tablet to unlock a wireless device that you can pick up. While shopping and adding products to your basket, use the wireless device to scan barcodes.

Before leaving the store, just put the wireless device back, use the tablet to pay.

We have APIs for the tablet and each wireless devices, and also a stomp server. Needless to say between http long polling and your exquisite kotlin lib, the choice was a no brainer.

Custom header are needed in the connect frame to identify tablets and wireless devices. We also have a jwt token for Auth.

As a side note, you should consider adding a donate button.

On Fri, Sep 4, 2020, 17:47 Joffrey Bion [e-mail] wrote:

@Mostrapotski https://github.com/Mostrapotski out of curiosity, which platform are you using Krossbow on? What’s your use case?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joffrey-bion/krossbow/issues/64#issuecomment-687231804, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWCL7NUZ27LRKRQJMZCUSTSEEDY3ANCNFSM4QXVLYOA .

[Mostrapotski]

Forgot to say it’s all android.

On Fri, Sep 4, 2020, 18:21 Dimitri Canonne [e-mail] wrote:

I work for a French retailer (red branding, I believe you can guess who it is!)

When entering the store, you can scan a loyalty card on a tablet to unlock a wireless device that you can pick up. While shopping and adding products to your basket, use the wireless device to scan barcodes.

Before leaving the store, just put the wireless device back, use the tablet to pay.

We have APIs for the tablet and each wireless devices, and also a stomp server. Needless to say between http long polling and your exquisite kotlin lib, the choice was a no brainer.

Custom header are needed in the connect frame to identify tablets and wireless devices. We also have a jwt token for Auth.

As a side note, you should consider adding a donate button.

On Fri, Sep 4, 2020, 17:47 Joffrey Bion [e-mail] wrote:

@Mostrapotski https://github.com/Mostrapotski out of curiosity, which platform are you using Krossbow on? What’s your use case?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joffrey-bion/krossbow/issues/64#issuecomment-687231804, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWCL7NUZ27LRKRQJMZCUSTSEEDY3ANCNFSM4QXVLYOA .