question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature] Allow Custom Secondary Color

See original GitHub issue

Is your feature request related to a problem? Please describe.

When setting up a new project i use the projects primary color and set it to peacock.color and then peacock does its magic and creates a new workbench.colorCustomizations object. This is great, but sometimes I want to tweak secondary colors to better match my projects brand. I can go into .vscode/settings.json and change them to suit my needs. The issue is next time I open the project. Peacock overrides my workbench.colorCustomizations object. I am not sure if there is a way to prevent “workbench.colorCustomizations” changes from being overridden every time or a peacock override object that we can use to fine tune the color scheme… I see you can set lighten/darken overrides, but cant change the color values

Describe the solution you’d like One solution could be add a

"peakcock.customizationOverides": {
   "activityBar.background": "#aeebdf"
}

Then when peacock grabs my peacock.color and sets up the workbench colors it would pull in the overrides instead of creating an entirely new Color Cusomizations object deleting the tweaks I previously made.

Thanks again for a great extension!

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:4
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
johnpapacommented, Mar 28, 2020

one option could be to allow setting the secondary color yourself.

this may cause a11y issues, but if you do it then it is your call, ya know? so maybe that’s an option for a future feature. would that cut it? not saying I can take it on right now, but is this on the right track?

1reaction
presto2116commented, Feb 11, 2020

An example I am thinking of is if I have given peacock a color and it does its thing and styles my project accordingly, I may not like the secondary color it uses for the activityBarBadge.background Lightening/darkening will never change the color of these items.

I agree with you on the consequences of adding this feature. you probably can think of more than I can, but first that comes to mind is on randomization/changing peacock color, these customizationOverides would stay in place and have negative consequences.

My current solution is run peacock. adjust my .vscode/settings.json and then disabling peacock on that project (if I have custom styling). it works. and may be to easiest solution.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Create a Two Color Brush in Procreate (using secondary ...
This tutorial will show you how to create a brush that paints with two different colors using the Secondary Color feature in Procreate...
Read more >
Create or delete a custom theme color
On the Themes tab, under Theme Options, click Colors, and then click Create Theme Colors. · Click a color that you want to...
Read more >
How To Configure Application Color Schemes With CSS ...
In this article, Artur Basak introduces a modern approach on how to set up CSS Custom Properties that respond to the application colors....
Read more >
Designing a Material Theme: Color
Material Design includes a comprehensive color system that allows designers ... The color theme has slots for primary and secondary colors, ...
Read more >
Add Custom Theme Colors to In-App Guidance
You can also switch to a dark color value for each color. Three examples of the dark color value custom theme colors. See...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found