[Feature] Allow Custom Secondary Color
See original GitHub issueIs your feature request related to a problem? Please describe.
When setting up a new project i use the projects primary color and set it to peacock.color and then peacock does its magic and creates a new workbench.colorCustomizations
object. This is great, but sometimes I want to tweak secondary colors to better match my projects brand. I can go into .vscode/settings.json and change them to suit my needs.
The issue is next time I open the project. Peacock overrides my workbench.colorCustomizations
object.
I am not sure if there is a way to prevent “workbench.colorCustomizations” changes from being overridden every time or a peacock override object that we can use to fine tune the color scheme…
I see you can set lighten/darken overrides, but cant change the color values
Describe the solution you’d like One solution could be add a
"peakcock.customizationOverides": {
"activityBar.background": "#aeebdf"
}
Then when peacock grabs my peacock.color and sets up the workbench colors it would pull in the overrides instead of creating an entirely new Color Cusomizations object deleting the tweaks I previously made.
Thanks again for a great extension!
Issue Analytics
- State:
- Created 4 years ago
- Reactions:4
- Comments:6 (4 by maintainers)
Top GitHub Comments
one option could be to allow setting the secondary color yourself.
this may cause a11y issues, but if you do it then it is your call, ya know? so maybe that’s an option for a future feature. would that cut it? not saying I can take it on right now, but is this on the right track?
An example I am thinking of is if I have given peacock a color and it does its thing and styles my project accordingly, I may not like the secondary color it uses for the
activityBarBadge.background
Lightening/darkening will never change the color of these items.I agree with you on the consequences of adding this feature. you probably can think of more than I can, but first that comes to mind is on randomization/changing peacock color, these customizationOverides would stay in place and have negative consequences.
My current solution is run peacock. adjust my .vscode/settings.json and then disabling peacock on that project (if I have custom styling). it works. and may be to easiest solution.