pydecimal provider with positive=True sometimes returns zero

• Faker version: 13.3.4
• OS: Ubuntu 18.04.6

Call pydecimal with positive=True, and it’ll sometimes return a zero.

Steps to reproduce

Here’s an example:

import faker

f = faker.Faker()
are_zero = [f.pydecimal(positive=True, right_digits=0) == 0 for _ in range(1000)]
print(any(are_zero))

Expected behavior

It should always print False.

Actual behavior

Sometimes it’s True with f.pydecimal() returning zero.

[fcurella]

@Tayum Thanks, I wasn’t aware of Decimal.next_plus().

@jhbuhrman I agree with everything you said. pydecimal needs be locale-aware, which means we’ll need an additional python provider for nl_BE and fr_BE, at least.

In the docs, we’ll also have to mention that the meaning of positive is locale-dependent. I don’t think most people realize that.

[github-actions[bot]]

This issue was closed because it has been inactive for 14 days since being marked as stale.