Respect `disable_tab_width_auto_detection` when Prettier config is present

Explain the Issue and Expected Behavior

By default JsPrettier derives tabWidth Prettier option from indentation detected by Sublime Text (which is controlled by disable_tab_width_auto_detection setting). However, if there is a Prettier config file present, this setting isn’t respected instead falling back to Prettier default setting tabWidth: 2 even if tabWidth isn’t set in Prettier config file.

It is expected for JsPrettier to obey disable_tab_width_auto_detection parameter unless tabWidth is set in Prettier config file as described in README.md.

Prettier version

1.16.4

JsPrettier Plug-in Version

1.25.0

Platform Details

• Sublime Text Version: 3.2
• Sublime Text Build: 3200
• Sublime Text Architecture: x64
• Operating System Name: macOS
• Operating System Version: 10.14.3 (18D109)
• Operating System Architecture: x64

Generated Prettier command line arguments

[JsPrettier DEBUG]: Prettier config file discovered at '/Users/schrodinger_cat/.prettierrc.json'

-----------------------------------------
 JsPrettier DEBUG - Prettier CLI Command 
-----------------------------------------

/usr/local/bin/prettier --stdin --config /Users/schrodinger_cat/.prettierrc.json --config-precedence cli-override --parser babel --use-tabs false --stdin-filepath /Users/schrodinger_cat/Documents/Source/macos/dotfiles/Library/Scripts/Applications/Transmit/SyncFavourite.js --loglevel debug --cursor-offset 706

Prettier reported the following output:

[debug] normalized argv: {"_":[],"color":true,"editorconfig":true,"stdin":true,"use-tabs":false,"config":"/Users/schrodinger_cat/.prettierrc.json","config-precedence":"cli-override","parser":"babel","stdin-filepath":"/Users/schrodinger_cat/Documents/Source/macos/dotfiles/Library/Scripts/Applications/Transmit/SyncFavourite.js","loglevel":"debug","cursor-offset":706,"plugin-search-dir":[],"plugin":[],"ignore-path":".prettierignore","debug-repeat":0}
[debug] load config file from '/Users/schrodinger_cat/.prettierrc.json'
[debug] loaded options `{"semi":false,"singleQuote":true}`
[debug] applied config-precedence (cli-override): {"filepath":"/Users/schrodinger_cat/Documents/Source/macos/dotfiles/Library/Scripts/Applications/Transmit/SyncFavourite.js","cursorOffset":706,"parser":"babel","semi":false,"singleQuote":true,"useTabs":false}

Prettier process finished with exit code 0.

Is the same behavior observed when run against Prettier directly?

Yes.

The contents of your User/JsPrettier.sublime-settings file

Empty.

The contents of your <project_name>.sublime-project file

Empty.

The contents of your .prettierrc.json file

Doesn’t contain tabWidth parameter:

{
    "semi": false,
    "singleQuote": true
}

Steps to reproduce the behavior

1. Create Prettier config file without tabWidth parameter set.
2. Omit disable_tab_width_auto_detection parameter or set it to false in JsPrettier settings.
3. Open file where Sublime Text detects indentation 4.
4. Use JsPrettier to format file.

[andreiborisov]

Especially since the plugin seems to be already ignoring parser and useTabs settings from config files:

/usr/local/bin/prettier --stdin --config /Users/schrodinger_cat/.prettierrc.json --config-precedence cli-override --parser babel --use-tabs false --stdin-filepath /Users/schrodinger_cat/Documents/Source/macos/dotfiles/Library/Scripts/Applications/Transmit/SyncFavourite.js --loglevel debug --cursor-offset 706

Maybe it’s still a bug?

I think using detected Sublime Text indentation for tabWidth unless disable_tab_width_auto_detection is set to true is the most logical behaviour.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.