Fragment state doesn't work when there is a module of the same name

https://gist.github.com/Pyrolistical/882622fe00822418783dc63edcf04bf6

Demo

actions: {
  doubleUsingGlobal(state, actions) {
    return {
      counter: {
        count: 2 * state.counter.count
      }
    }
  },
  // this doesn't work due to module vs fragment conflict
  counter: {
    doubleUsingFragment(state, actions) {
      return {
        count: 2 * state.count
      }
    }
  }
},
modules: {
  counter
}

doubleUsingGlobal breaks the module due to #437, but is unrelated to this issue

[SkaterDad]

It seems like a good candidate for “dev build” warnings. Conflicting namespaces just need to be avoided, in my opinion.

Does the current documentation make it clear that modules will occupy the namespace you assigned in the larger state/actions trees?

I see no issue with the current behavior, honestly.

[jorgebucaran]

Without a solution for this, there is only one way to monkey patch a module.

doubleUsingGlobal(state, actions) {
  return {
    counter: {
      count: 2 * state.counter.count
    }
  }
}

That will replace the entire counter slice with a new counter object, instead of updating count’s value.

counter: {
  doubleUsingFragment(state, actions) {
    return {
      count: 2 * state.count
    }
  }
}

Now, that will work just as if doubleUsingFragment was an action under the counter slice and update only count.

On the other hand, you still can’t monkey patch an action, as the module’s definition will take precedence, so maybe there is too little gain adding a solution for this.

I am going to close here with wontfix. But I am willing to revisit this in the future if the issue comes up again.