Style attribute isn’t set in DOM

Hi! Thank you for the lib!

Ran into an issue with a missing style tag:

const { h } = require('picodom')
const hyperx = require('hyperx')
const html = hyperx(h, {attrToProp: false})

const a = html`<div style="height: 100%; background-color: red;">123</div>`
console.log(a)

console:

DOM:

<div>123</div>

Tried in the example pen (thought maybe hyperx is to blame), same thing:

https://codepen.io/anon/pen/jLvjOQ?editors=0110

[mindplay-dk]

Having thought more about this, I’ve changed my mind.

One reason not to support strings, is it makes it impossible to incrementally patch CSS properties, since you can’t directly diff between a string and an object - or, at least not without rolling out a CSS parser for the string first, which is likely out of the question. So, if we support strings, we’ll invite weird edge-cases where the style-property changes to/from a string/object.

Another argument is why use strings in the first place? Is there ever a good reason to do that?

The use of style in the first place, is likely mostly interesting for things like toggling state (collapse/expand, etc.) and hopefully never as a means of actually styling UI elements - for that, a CSS-in-JS framework, or just a good’ol CSS file and the class attribute, are likely much preferable. It’s likely not worth sweating over?

[leeoniya]

I find life without surprises rather boring.

this is more “surprise, a flat tire!” than “surprise, a trip to italy!”. to be fair, i do prefer all my network switches to randomly drop packets; i haven’t bought a boring, predictable switch in years. 😆