Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow to override tradePath

See original GitHub issue

I’m trying to execute trades from WETH -> other tokens, and I really want to use the WETH that the account already owns. It seems that the automatic getTradePath then always makes the transaction between unwrapped ETH -> token. For my purpose it would be great if the tokenpair (or createFactory) has an optional parameter to force the tradepath to stay erc20ToErc20 even though one of the tokens is WETH.

Issue Analytics

State:
Created 2 years ago
Comments:37 (22 by maintainers)

Top GitHub Comments

1reaction

joshstevens19commented, Jul 7, 2021

yes so any testnets default to direct routes it doesn’t try to go down many routes… (aka basically it uses disableMultihops in the background on anything but MAINNET) and as right now you cant do ETH > WETH directly it say that! As said its on list for direct swap just not had time to relook yet

1reaction

joshstevens19commented, Jul 5, 2021

Hey, guys just a heads up tomorrow I’m going to look at a nicer way to handle useWETHAsERC20Route flag, I want to create a NATIVE_ETH property you pass in instead of the WETH logic (similar to what @mathijs81) was suggesting, if you want native and if you want WETH you pass in WETH contract address, this way it’s a very clear interface for devs to know how to make it work with both native + WETH.

I think I will also remove this flag as this approach seems a bit backwards (and confusing) once we clear up the way you work with native and weth in the sdk.

This is mainly due to the ability to swap WETH > ETH and the other way around, right now the library with the current approach does not support that logic, which it should!

This will also clear up the confusing @mathijs81 talked about where you get WETH balances in ETH and the other way round. So just a heads up if you do see it break on an npm install circle back to this thread. I will include the breaking changing details here and bump it to 3.0.0 once it’s done!

Due to the way the docs suggest people use it aka using WETH.. I will probably depreciate WETH static class and make it point to NATIVE_ETH and then create a new WETH_CONTRACT class, I have not worked out full details yet but wanted to let you guys know.

Thanks