New dependency react-spinners increases build size
See original GitHub issueI tried out react-images
in version 0.5.15
and 0.5.16
. Compared to 0.5.14
the resulting bundle size increase alot, adding ~90 kb of uglified, but not-gzipped payload.
One way to measure it, is this way:
Steps to reproduce the behavior:
- Call
yarn webpack --progress -p
Expected behavior:
app.js
should not be too big (ideally around ~190 kb, as with 3d48f4766112f7f93b6555b3b1907331bfcc0583)
Actual behavior:
app.js
is quite big (currently ~277 kb, as with 7f229b1078ccba0b70a9b93e8ed03db903f40689)
It appears, that the biggest difference between those versions is https://github.com/jossmac/react-images/pull/187. That PR added a new dependency to http://www.davidhu.io/react-spinners/.
Issue Analytics
- State:
- Created 6 years ago
- Comments:10 (8 by maintainers)
Top Results From Across the Web
react-spinners - npm
size , height , width , and radius props. The input to these props can be number or string. If value is number,...
Read more >React Spinner: Building a React Spinner Component with Bit
In this article, you will learn how to create a React spinner component with Bit and how to use it on a React-App...
Read more >react-spinners/CHANGELOG.md at main - GitHub
Replaced @emotion with vanilla javascript and inline style to reduce component size by 75%. This project now have 0 dependencies, while continuing to...
Read more >Adding spinners and notifications to your React app
Notifications and loading spinners can go a long way toward making your React app more user-friendly. Learn how to implement them in an ......
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@apepper @jorrit @neptunian
I’ve removed
react-spinners
dependency and implemented default spinner in #208. You can also implement your own custom spinner, see examples. 😃@neptunian sounds good, I’ll be able to solve it this weekend.