failed tests

I co-maintain the python-jwt package in Fedora for PyJWT. The test suite is now failing in Fedora 30 and I’m not sure why. The failing tests are:

• TestJWS.test_decode_no_algorithms_verify_signature_false
• TestJWT.test_decode_no_algorithms_verify_false

Expected Result

Tests to pass (just like they did in Fedora 29).

Actual Result

_______________________________________ TestJWS.test_decode_no_algorithms_verify_signature_false _______________________________________

self = <tests.test_api_jws.TestJWS object at 0x7f03249037b8>, jws = <jwt.api_jws.PyJWS object at 0x7f0324903128>

    def test_decode_no_algorithms_verify_signature_false(self, jws):
        example_secret = 'secret'
        example_jws = (
            b'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.'
            b'aGVsbG8gd29ybGQ.'
            b'SIr03zM64awWRdPrAM_61QWsZchAtgDV3pphfHPPWkI'
        )
    
        try:
            pytest.deprecated_call(
                jws.decode, example_jws, key=example_secret,
>               options={'verify_signature': False},
            )
E           Failed: DID NOT WARN. No warnings of type (<class 'DeprecationWarning'>, <class 'PendingDeprecationWarning'>) was emitted. The list of emitted warnings is: [].

tests/test_api_jws.py:295: Failed
____________________________________________ TestJWT.test_decode_no_algorithms_verify_false ____________________________________________

self = <tests.test_api_jwt.TestJWT object at 0x7f0324d987f0>, jwt = <jwt.api_jwt.PyJWT object at 0x7f0324d8c748>
payload = {'claim': 'insanity', 'exp': 1541389632, 'iss': 'jeff'}

    def test_decode_no_algorithms_verify_false(self, jwt, payload):
        secret = 'secret'
        jwt_message = jwt.encode(payload, secret)
    
        try:
            pytest.deprecated_call(
>               jwt.decode, jwt_message, secret, verify=False,
            )
E           Failed: DID NOT WARN. No warnings of type (<class 'DeprecationWarning'>, <class 'PendingDeprecationWarning'>) was emitted. The list of emitted warnings is: [].

tests/test_api_jwt.py:517: Failed

Full output: https://gist.github.com/carlwgeorge/563597c80e3324101d754efac99d14a1

Reproduction Steps

yum install python3-{devel,setuptools,cryptography,pytest,pytest-cov}
wget https://files.pythonhosted.org/packages/source/P/PyJWT/PyJWT-1.6.4.tar.gz
tar -xf PyJWT-1.6.4.tar.gz
cd PyJWT-1.6.4
pytest-3 -v

System Information

$ python -m jwt.help

$ python3 -m jwt.help
{
  "cryptography": {
    "version": "2.3"
  },
  "implementation": {
    "name": "CPython",
    "version": "3.7.1"
  },
  "platform": {
    "release": "4.18.16-300.fc29.x86_64",
    "system": "Linux"
  },
  "pyjwt": {
    "version": "1.6.4"
  }
}

[dotlambda]

It’s said to see you’re viewing pinning the pytest version as a solution to this.

[jpadilla]

https://github.com/jpadilla/pyjwt/releases/tag/1.7.1