Official docker image need more modules

I have been following issue 341 and is really excited to be able to use it, however I think it needs some of the prerequisites added to the Dockerfile.

For example the following log entries work on my standalone install:

mqttwarn        | 2018-10-30 11:19:16,856 DEBUG [slack] *** MODULE=services/slack.py: service=slack, target=openhabalarm
mqttwarn        | 2018-10-30 11:19:16,857 ERROR [slack] slacker module missing
mqttwarn        | 2018-10-30 11:19:16,858 WARNING [mqttwarn] Notification of slack for '/openhab/notification/alarm' FAILED or TIMED OUT
mqttwarn        | 2018-10-30 11:19:16,859 DEBUG [mqttwarn] Job queue has 5 items to process
mqttwarn        | 2018-10-30 11:19:16,859 DEBUG [mqttwarn] Processor #0 is handling: 'pushbullet' for david
mqttwarn        | 2018-10-30 11:19:16,864 DEBUG [pushbullet] *** MODULE=services/pushbullet.py: service=pushbullet, target=david
mqttwarn        | 2018-10-30 11:19:16,865 WARNING [pushbullet] pushbullet is not installed
mqttwarn        | 2018-10-30 11:19:16,866 WARNING [mqttwarn] Notification of pushbullet for '/openhab/notification/alarm' FAILED or TIMED OUT

On the normal install I am able to install the dependencies, but the docker image mean I need to build my own for my specific needs unless you could add some of the popular ones at least.

Many thanks in advance!

[rgitzel]

I did an experiment to create a Docker image which includes as many dependencies as I could find reading through the README: https://github.com/rgitzel/mqttwarn/blob/docker-dependencies/Dockerfile#L5

With all those dependencies added, the Docker image is 420Mb

With very few dependencies, the “official” image built yesterday is 356Mb

So basically installing all the extra libraries results in no appreciable difference in size.

Then I modified it to use Alpine as the base OS, which reduced the image to 117Mb

That’s indeed smaller, but frankly I don’t think it’s worth the work sorting out all the picky library bits that are missing from Alpine (indeed, the Azure library would be painful). 420Mb isn’t anything out of the ordinary, particularly for a server application.

CAVEAT: I haven’t tested either of these images beyond running them on the command-line:

$ docker run -t rgitzel/mqttwarn-full
Cannot open configuration at /opt/mqttwarn/conf/mqttwarn.ini: [Errno 2] No such file or directory: '/opt/mqttwarn/conf/mqttwarn.ini'

Because Python is interpreted, the app probably won’t fail for a given plugin until it’s run. But at least those many dependencies installed without any apparent conflict.

@tinuva could you give one or both of the new images a try? rgitzel/mqttwarn-full-alpine and rgitzel/mqttwarn-full. They hopefully have everything installed that you need.

And if anyone notices any dependency I missed (other than the Mac-dependent ones), let me know and I’ll add them.

[egadgetjnr]

Hey Guys, Just my 2 cents on this one being somewhat an experienced docker user.

I think going down the path of having ALL the modules installed on an image would be somewhat troublesome as it would increase the image size exponentially.

Also, Using a tag to define the modules would also be difficult if there is more than one module requirement. How would you be able to use Pushbullet and MySQL and hipchat all in the one image?

@amotl is on the money though with having a command that you can run to install them, as you’d be able to use your own dockerfile to specify the modules you want if need be. Failing that, could you use arguments to install the plugins on first run? That way when you use ‘docker run’ you will be able to pass arguments for the module installation at the end of the command. Both of these approaches are what other developers use for their docker repos and it allows full customisation of different scenarios.