Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix `package.json` in `eslint-config-modular-app`

See original GitHub issue

Should we match https://github.com/facebook/create-react-app/blob/2da5517689b7510ff8d8b0148ce372782cb285d7/packages/eslint-config-react-app/package.json#L17-L27 and specify them as peerDependencies instead? You wouldn’t want dependencies like typescript to be brought in via an ESLint config package.

_Originally posted by @NMinhNguyen in https://github.com/jpmorganchase/modular/pull/27_

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

sebinsuacommented, Sep 7, 2020

(I’ll let @NMinhNguyen make this change because he has more opinions than I do on this, but I do think that typescript should always be at the root of the project, since otherwise it’d be awkward to update this.)

1reaction

NMinhNguyencommented, Sep 6, 2020

We’d just match CRA with regards to peer deps, at least for dependencies that categorically shouldn’t be duplicated in a repo. But I think that none of these should really be regular deps as they can cause hard-to-debug issues such as unexpected versions of plugins being resolved (especially imagine a repo with existing linting). Also eslint-plugin-react is notorious for having breaking changes from release to release.