5.0.0 Test suite broken on Node.js 8.x and 9.x

• Operating System: OSX
• Node.js version: 8.x / 9.x
• fs-extra version: 5.0.0 || master

The test for this module is not currently passing with Node.js 8.x or 9.x. and it appears to be 0bd52793a2e15b593ce3f19167d2550e822665a3 that broke it

[MylesBorins]

Indeed, sorry for not being exact

On Jan 10, 2018, at 10:02 AM, Ryan Zimmerman [e-mail] wrote:

@MylesBorins https://github.com/mylesborins I assume you mean https://github.com/nodejs/node https://github.com/nodejs/node when you say the main repo?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jprichardson/node-fs-extra/issues/536#issuecomment-356628356, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecVzXGxxLTAtjMn_302WG5eYwAfpkIks5tJNECgaJpZM4RY1jo.

[MylesBorins]

You should open an issue against the main repo… This may be something broken in libuv

On Jan 10, 2018 9:45 AM, “Ryan Zimmerman” [e-mail] wrote:

This is weird; it seems the Node.js copyFile and copyFileSync methods aren’t consistent between Mac and Linux. On Mac, it seems to always preserve timestamps, while the timestamp is changed on Linux. Here’s a test case repo: https://github.com/RyanZim/fs-copy-file-test Note that this is testing the fs methods directly; not fs-extra. The tests pass on Linux, as the timestamps are changed; they fail on Mac since the timestamps are preserved.

I’m not sure how fs-extra should handle this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jprichardson/node-fs-extra/issues/536#issuecomment-356622984, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecV10JVQAWkfeDHad2VddVi5dC8kI6ks5tJM0FgaJpZM4RY1jo .