yup's array validation is broken

Describe the bug When using yup with an array and pass it a shape, there are no errors returned, even if the object is invalid.

To Reproduce

const invalidObj = {
  message: 'hello',
  numbers: ['hello'],
  tokens: [{ name: 1, id: true }]
};

const yupObject = yup.object().shape({
  message: yup.string().required(),
  numbers: yup
    .array()
    .of(yup.number().required())
    .required(),
  tokens: yup
    .array()
    .of(
      yup.object().shape({
        name: yup.string().strict().required(),
        id: yup.string().strict().required()
      })
    )
    .required()
});
const res = await yupObject
  .validate(invalidObj, { abortEarly: false })
  .catch(({ errors }) => errors);
console.log('res', res);

Logs out:

res [
      'numbers[0] must be a `number` type, but the final value was: `NaN` (cast from the value `"hello"`).'
    ]

Even though it should catch that name and id aren’t the correct type.

Expected behavior Yup should see the invalid types and log out errors that name and id must be strings.

Platform (please complete the following information):

• Browser: chrome
• Version: 0.27

[janhesters]

@jquense I just found the bug and its on my end. I left out strict from the array. If you change the schema to:

const yupObject = yup.object().shape({
  message: yup.string().required(),
  numbers: yup
    .array()
    .of(yup.number().required())
    .strict()
    .required(),
  tokens: yup
    .array()
    .of(
      yup.object().shape({
        name: yup.string().strict().required(),
        id: yup.string().strict().required()
      })
    )
    .strict()
    .required()
});

It does the proper validation.

[janhesters]

This looks like a real bug, the issue is that the strings are still being cast from the boolean and number, even tho they are marked as strict

Thank you! Sounds right 😊