Cookies.get() always returns empty when used with jsdom.

In this block of code:

if (this.json) {
  try {
    cookie = JSON.parse(cookie);
  } catch (e) {}
}

If this is undefined, it will throw an error causing a Cookies.get() to always return an empty {}.

The solution is to change the conditional to the following:

if (this && this.json) {
  try {
    cookie = JSON.parse(cookie);
  } catch (e) {}
}

This is only failing in my test suite where jsdom is used instead of a browser. Everything seems to work in the browser.

Working on a PR.

[FagnerMartinsBrack]

@dmatteo

Does that help in any way?

I will take a look for v2.1.4.

[dmatteo]

Hey @FagnerMartinsBrack, I finally managed to get around this thread and try and reproduce whatever issue was here, without success though, or actually without failures…

I’ve created a small repo here https://github.com/dmatteo/jsCookieRepro that will also help clear out the jsdomify.default case. Good point on the fact that the CommonJS use case is not documented on the README, I will add that asap.

There are 3 branches on the repo:

• master: running on jsdomify 3.0.0 which depends on jsdom 9.4.2
  • It’s using ES6 syntax, including ES6 modules: import jsdomify from 'jsdomify'
  • Tests can be run with ./node_modules/.bin/mocha --compilers js:babel-register
• no-transpiling: running on jsdomify 3.0.0 which depends on jsdom 9.4.2
  • Dear 'ol ES5, which means var jsdomify = require('jsdomify').default
  • The .default part is not a jsdomify specific thing, but it’s there because the library is exported as a default ES6 module and then transpiled via babel before publishing, so it can be used also via CommonJS
  • Tests can be run with ./node_modules/.bin/mocha
• jsdomify-2: running on jsdomify 2.1.0 which depends on jsdom 8.2.0
  • Again ES6 here, but using the version of jsdomify that was mentioned in the issue here.
  • Tests can be run with ./node_modules/.bin/mocha --compilers js:babel-register

---

All the (2) tests in the 3 branches passes, so I’m not sure what was the issue here.

Does that help in any way?