Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
jQuery .val() method on a cloned form element doesn't update its value attribute
See original GitHub issueI had a weird problem using zombie.js for a functional test of some production cloning script. It seems that using jQuery’s val() on a cloned, unattached element doesn’t work as it would in-browser. Here’s a stripped-down scenario to reproduce it:
<html><body>
<form>
<input type="text" id="sourceField" name="field" value="should not expose this">
</form>
<script>
(function($) {
var $template = $('#sourceField').clone();
$template.val('');
var $new = $template.clone();
// in production code, would rename and append here
console.log($new.prop('name') + ': ' + $new.val());
})(jQuery);
</script>
</body></html>
Running this in a browser console, you see:
field:
In zombie.js, the console shows:
field: should not expose this
If I replace the $template.val(''); with $template.attr('value', '');then the code works consistently in both. It seems that the .val() method doesn’t update the value attribute of the cloned node, which allows its content to persist across further clone operations.
I see it using jQuery 1.8 through 1.11.1. Looking at the jQuery code it seems that it should be a pretty straightforward assignment. I’d welcome someone with better knowledge of jsdom taking a quick look to see if it’s an obvious bug in how it’s handled.
Issue Analytics
- State:
- Created 9 years ago
- Comments:15 (14 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
I assume you mean this part:
Will do! Going to see if there are any WPT for this, otherwise will create a new one in to-upstream.
Fixed by https://github.com/tmpvar/jsdom/pull/1547, yay!