JSDOM accepts a buffer but doesn't allow to set a content type encoding and defaults to windows-1252

Basic info:

• **Node.js version: 8.10
• **jsdom version: 13.1

Minimal reproduction case

const { JSDOM } = require("jsdom");
const dom = new JSDOM(buffer, {
  contentType: res.headers['content-type'], // Doesn't use the charset from content-type
  encoding: 'UTF-8' // Doesn't use the passed encoding
});

It should either automatically extract charset from options.contentType, or it should allow to pass options.encoding.

Internally it’s using transportLayerEncodingLabelHiddenOption to pass the encoding, therefore fromURL method works correctly.

https://github.com/jsdom/jsdom/blob/master/lib/api.js#L33

[domenic]

Well, the contentType option is not the same as a content-type header. You can’t supply headers with a Buffer.

But, maybe we should treat it similarly, instead of only treating it as an XML vs. HTML mode switch. Hmm.

[csmr]

Am I understanding correctly: the html5-documents meta-tags Content-Type with charset=UTF-8 is ignored when “handling a buffer”?

It seems to me, that this will destroy your document unless it is encoded with the default charset.

Also, please note that a browser will look for the meta http-equiv=“Content-Type” for encoding information , and if it is found, re-parse the document with the specified encoding.

With that, it seems to me this is not a desired feature.