MutationEvent.js reference to not existing MutationEvent-impl.js Webpack compiler fails 9.12.0
See original GitHub issueHello,
I use jsdom for svg generation and I compile it with webpack to one file. The webpack compiler fails with following error:
ERROR in ./~/jsdom/lib/jsdom/living/generated/MutationEvent.js Module not found: Error: Cannot resolve 'file' or 'directory' ../events/MutationEvent-impl.js in /home/test/work/git/j5-framework/j5/src/webui/node_modules/jsdom/lib/jsdom/living/generated @ ./~/jsdom/lib/jsdom/living/generated/MutationEvent.js 174:13-55
I checked different versions of jsdom and until version 8.5.0 the missing MutationEvent-impl.js was still in the package. From version 9.0.0 it disappears. From version 9.0.0 MutationEvent.js is also not reference anymore in jsdom/living/index.js. But the file is still in the npm package under living/generated/MutationEvent.js
I assume it has been removed at some stage but the “npm run convert-idl” doesn’t clean the “generated” folder?
In current version 9.12.0 the file ’ MutationEvent.js’ is still in the npm package.
Issue Analytics
- State:
- Created 7 years ago
- Comments:5 (2 by maintainers)
Top GitHub Comments
Yeah, we probably have some leftover files in the package. You should probably use a bundler tool like browserify which determines the files by crawling the dependency graph, instead of one like webpack which apparently just looks at whatever is on the filesystem. That’s a bad strategy which we don’t support.
Fixed now, and probably in a way that won’t reoccur 😃