Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Bug: crash on 404 when resource ID type does not match query string
See original GitHub issueDescription
See https://github.com/json-api-dotnet/JsonApiDotNetCore/issues/631#issuecomment-559562320
Looking at the changes, the trim/split/findindex url parsing feels a bit brittle to me. Wouldn’t it be an option to use the route values, like it is done at: https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/d9dd76069a35bfbd8bb180ff83213014d2601b10/src/JsonApiDotNetCore/Middleware/CurrentRequestMiddleware.cs#L251?
For example, the debugger shows me for the request path:
api/v3/users/ABC/completions
these route values:
{
"action": "GetRelationship"
"controller": "Users"
"id": "ABC"
"relationshipName": "completions"
}
Hope this helps.
Issue Analytics
- State:
- Created 4 years ago
- Comments:9 (9 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
I getcha, but will work on this tomorrow.
/cc @wisepotato