Calling 'AddJsonApi' bypass all the exception handler middlewares

Description

Before using JsonApiDotNetCore, I had an ASP.NET Core middleware that had the responsibility to reformat all exceptions that occured in my controllers. This middleware was almost identical to this one.

As soon as I started to use JsonApiDotNetCore by calling AddJsonApi, my middleware stopped working. This is because AddJsonApi registers an exception filter:

https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/8570b216c7ede3a7b5f9fc7a4912404a14926df5/src/JsonApiDotNetCore/Extensions/IServiceCollectionExtensions.cs#L82

This exception filter handles all exceptions. My middleware is therefore unable to detect the exception.

Is there a way to disable this exception filter or to limit this exception filter to the routes that to use JSONAPI? My routes that don’t use JSONAPI should still use my exception middleware.

Environment

• JsonApiDotNetCore Version: 3.1.0.0

[jaredcnance]

Another option would be to just inspect the ContentType of the request and only handle failures for application/vnd.api+json

[mabead]

Providing my own exception filter sure is a powerful option. But I feel that calling AddJsonApi should not change the behavior of an existing code base (which it currently does). New users of JsonApiDotNetCore won’t typically dig in the details of how this call affects the ASP.NET Core pipeline. Instead, JsonApiDotNetCore should, in my opinion, be as friction free as possible. I would suggest to add something like the following at the beginning of JsonApiExceptionFilter.OnException:

var controllerActionDescriptor = context.ActionDescriptor as ControllerActionDescriptor;
if (controllerActionDescriptor == null)
{
    return;
}

var mixinControllerType = typeof(JsonApiControllerMixin);
if (!mixinControllerType.IsAssignableFrom(controllerActionDescriptor.ControllerTypeInfo))
{
    return; // Error is not from a JSONAPI controller. Don't intervene in the process.
}

What do you think of the idea?

In the mean time, I have no choice but to manually remove the JsonApiExceptionFilter from the list of filters added to MVC.