fix validation

General information

• json-editor version: 2.0-dev
• I fixed a few other tests before (minor errors), but the validations for certain objects are not working correctly.
• Fixing this is a high priority to me, since validations are very important

https://travis-ci.org/json-editor/json-editor/jobs/571279410

Expected behavior

validation_test.js should pass.

Actual behavior

It doesn’t.

Steps to reproduce the behavior

Run tests from develop/2.x-fix-tests.

 codeceptjs run editors/validation_test.js 

The output with the failures:

required4 [test valid 0]: success
required4 [test invalid 0]: fail. Expected: errors, Actual: []
required4 [test invalid 1]: success
required4 [test invalid 2]: success
required4_merge [test valid 0]: success
required4_merge [test invalid 0]: fail. Expected: errors, Actual: []
required4_merge [test invalid 1]: fail. Expected: errors, Actual: []

The corresponding test data:

required4: {
            schema: {
                type: "object",
                properties: {
                    required: {}
                },
                required: ["required"],
                additionalProperties: true
            },
            valid: [
                {required: true, test: 1}
            ],
            invalid: [
                {},
                "a string",
                [1,2,3]
            ]
        },
        required4_merge: {
            schema: {
                type: "object",
                properties: {
                    orig: {},
                    other: {}
                },
                required: ["orig"],
                oneOf: [
                    {
                        required: ["other"]
                    }
                ]
            },
            valid: [
                {
                    orig: true,
                    other: true
                }
            ],
            invalid: [
                {
                    orig: true
                },
                {
                    other: true
                }
            ]
        },

So an empty object {} is now accepted, but it should trigger an error.

And oneOf seems not to be correctly evaluated, since only an object with orig AND other should be valid.

CC: @pmk65 @wclssdn Can you shed some light and/or fix this?

[pmk65]

@schmunk42 I found the culprit. It was the code I added for Button and Info editors in src/validator.js. I have pushed a fix to the develop/2.x branch.

[schmunk42]

Yes, we can do that, but on the other hand we’re running this test always in the CI.