ipv4 validation not implemented

General information

The ipv4 format specifies that the entered string should be in the format of an ipv4 address. I believe this was already specified in json schema v4 but doesn’t seem to be implemented in json-editor.

• json-editor version: 1.4.0-beta.0

Expected behavior

Should create a validation error if a non-valid ip address is entered into a string field specified with format ipv4.

Actual behavior

Does not raise a validation error.

Steps to reproduce the behavior

Direct link to example

{
  "title": "json schema example",
  "type": "object",
  "properties": {
    "ipAddress": {
      "type": "string",
      "format": "ipv4",
      "description": "IP address."
    }
  },
  "required": [
    "ipAddress"
  ]
}

[sirockin]

I wrote a custom validator below that will provide this validation. Would you like me to attempt to create a PR to include make it part of the default validation?

  JSONEditor.defaults.custom_validators.push(function(schema, value, path) {
    var errors = [];
    if(schema.format==="ipv4") 
    {
      try
      {
        let parts=value.split('.');
        if( parts.length !==4)
        {
          throw(Error());
        }
        parts.forEach((part)=>{
          if( isNaN(+part) || +part < 0 || +part>255)
          {
            throw(Error());
          }
        })
      }
      catch(err)
      {
        // Errors must be an object with `path`, `property`, and `message`
        errors.push({
          path: path,
          property: 'format',
          message: 'ip addresses must be in the form of 4 numbers between 0 and 255, separated by dots'
        });
      }
    }
    return errors;

[pmk65]

@sirockin Good idea, as both ipv4 and ipv6 is part of the 04 specs. https://tools.ietf.org/html/draft-fge-json-schema-validation-00#section-7.3.4 So the validation should support both versions. Also it might also be a good idea to create an “ip editor”. It just has to extend the “string” editor and set a validator pattern, similar to what I did in the UUID editor postBuild() function. https://github.com/json-editor/json-editor/blob/master/src/editors/uuid.js

IPv4 Regex pattern: ^(?:[0-9]{1,3}\.){3}[0-9]{1,3}$ IPv6 Regex pattern: ^(?:[A-F0-9]{1,4}:){7}[A-F0-9]{1,4}$

You can also find a lot of “ip” regex patterns here: https://regex101.com/library?orderBy=RELEVANCE&search=ip