question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update coding standards and decide which should be enforced by Eslint

See original GitHub issue

When I created the Webpack build, I transferred the linting mechanism from jshint to Eslint carrying over as best as I could the jshint rules from the old build. It wasn’t clear to me whether or not the jshint rules had been enforced by the build (ie the build fails if a rule is broken) so I left the linting as advisory.

Can we discuss and agree which (if any) rules we want to enforce, which we want to appear as a warning, and whether we want to mention and justify these in CONRIBUTING.md?

I can then updated the Eslint rules as agreed.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:15 (4 by maintainers)

github_iconTop GitHub Comments

3reactions
germanbisurgicommented, Sep 17, 2019

i recommend https://standardjs.com/ for eslint

2reactions
pmk65commented, Sep 17, 2019

If we want to enforce the rules, it should break the build. Just like the e2e tests do.

Read more comments on GitHub >

github_iconTop Results From Across the Web

ESLint: Everything You need to know about setting up a style ...
These tools also help developers to write better code by pointing out common errors and enforcing good programming patterns.
Read more >
Working with Rules - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
Setting up ESLINT in your JavaScript Project with VS Code
ESLINT helps to increase productivity, write your code according to standard and flag errors when your code base is breaking style guide rules....
Read more >
How Eslint Can Enforce Your Design System Best Practices
Here are our advices on how to use Eslint to enforce this ... Part 3: Encouraging Design System Best Practices with Eslint Rules....
Read more >
How To Lint and Format Code with ESLint in Visual Studio Code
Choose the To check syntax, find problems, and enforce code style option. Choose the CommonJS option to use CommonJS global variables. Choose ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found