question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Version number is missing from dist files

See original GitHub issue

According to CONTRIBUTING.md, there should be a version number in the dist file after an update.

The following is done when a pull request is accepted. There is no need to do any of these steps yourself. Increment version number in src/intro.js and bower.json. Set date in src/intro.js.

Expected behavior

/**
 * @name JSON Editor
 * @description JSON Schema Based Editor
 * Deprecation notice
 * This repo is no longer maintained (see also https://github.com/jdorn/json-editor/issues/800)
 * Development is continued at https://github.com/json-editor/json-editor
 * For details please visit https://github.com/json-editor/json-editor/issues/5
 * @version 1.2.3
 * @author Jeremy Dorn
 * @see https://github.com/jdorn/json-editor/
 * @see https://github.com/json-editor/json-editor
 * @license MIT
 * @example see README.md and docs/ for requirements, examples and usage info
 */

Actual behavior

/**
 * @name JSON Editor
 * @description JSON Schema Based Editor
 * Deprecation notice
 * This repo is no longer maintained (see also https://github.com/jdorn/json-editor/issues/800)
 * Development is continued at https://github.com/json-editor/json-editor
 * For details please visit https://github.com/json-editor/json-editor/issues/5
 * @version {{ VERSION }}
 * @author Jeremy Dorn
 * @see https://github.com/jdorn/json-editor/
 * @see https://github.com/json-editor/json-editor
 * @license MIT
 * @example see README.md and docs/ for requirements, examples and usage info
 */

Steps to reproduce the behavior

Look at the header on the link to the production version or the development version on the main repro page.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:17

github_iconTop GitHub Comments

1reaction
marc7000commented, Oct 30, 2018

Yes, it should. When i test this task it works, but when i run “npm version 1.2.0”, which then executes the “preversion”, “version” (do the string replace) & “postversion” script in “packages.json”, it doesn’t work. I will fix it as soon as possible.

1reaction
pmk65commented, Oct 30, 2018

Shouldn’t the “{{ VERSION }}” marker be substituted with current version during the build process?

Read more comments on GitHub >

github_iconTop Results From Across the Web

3.22.0 missing dist files on NPM · Issue #1363 - GitHub
The polyfills/__dist folder is missing on 3.22.0 on NPM, so the service fails to start with the error: No polyfill sources found.
Read more >
npm module missing files after publish - node.js - Stack Overflow
I have a prepublishOnly step that removes the dist folder, runs tsc, then runs the test against the transpiled js. The tests pass...
Read more >
Configuring build settings - AWS Amplify Hosting
version - Represents the Amplify YAML version number. ... artifacts>files - Specify files from your artifact you want to deploy.
Read more >
Deployment - Angular
The Angular CLI command ng deploy (introduced in version 8.3.0) executes the ... Configure the server to redirect requests for missing files to...
Read more >
Install and manage packages in Visual Studio using the ...
To do so, use the Consolidate tab of the NuGet Package Manager window to discover where packages with distinct version numbers are used...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found