`button-has-type` not recognizing default props

Hi,

looks like whatever I try the button-has-type rule can’t understand the default prop.

type Props = {
  type: 'submit' | 'button' | 'reset',
};

function Button({ type, ...extraProps }: Props) {
  return <button type={type} {...extraProps} />;
}

Button.defaultProps = {
  type: 'submit',
};

error  "null" is an invalid value for button type attribute  react/button-has-type

type Props = {
  type: 'submit' | 'button' | 'reset',
};

function Button({ type = 'submit', ...extraProps }: Props) {
  return <button type={type} {...extraProps} />;
}

error  "null" is an invalid value for button type attribute  react/button-has-type

[ljharb]

@truckingsim what i’d expect is that you’d have that Button component wrapped by SubmitButton and ResetButton components, and inside those you’d override the rule for the dynamic type - but you wouldn’t need that anywhere else.

(ofc, this is separate from the issue that reset buttons are terrible UX and shouldn’t ever be on the page)

[truckingsim]

@ljharb In our component library at my company we have a Button component that is used for various things. We use a oneOf prop type to do an enum of type options and default to button since that’s the sane default. But the button can be used technically as a submit or reset button (and does get used).

We have a component due to css and classes, its easier to have one shared one where the app people don’t have to worry about css classes and semantics, they can just use our Button.

I don’t want to turn this rule off, but if its going to be forced to be static, don’t really see another way.