react/destructuring-assignment: Add "minAttributes" option

This option would enable the rule only if at least n values are accessed. For example, with minAttributes=2 this would be OK:

class Foo extends React.PureComponent {
  render() {
    return <div>{this.props.foo}</div>;
  }
}

while this would trigger the rule’s warning:

class Foo extends React.PureComponent {
  render() {
    return <div>{this.props.foo} {this.props.bar}</div>;
  }
}

The idea for this option is that especially in small components that only use one single property it’s more convenient to not have to use destructuring (which does add one extra line of code!)

I wouldn’t mind creating a PR to add this option if it is likely to get merged.

[pferreir]

Other rules allow for options that most people will consider unorthodox (e.g. allowAllCaps in jsx-pascal-case). Would this option be that unanimously wrong that it wouldn’t be worth having? @ljharb I see your point and I fully agree with it. Still, I cannot help but be bothered by stuff like:

const {user} = this.state;
doWhatever(user);

If we’re talking of readability, I believe most programmers out there would understand this.state.user better.

[ljharb]

Convenience isn’t the priority; destructuring the props serves many useful purposes: for instance, for function props, it ensures they’re not called with the this value as the props object.

Optimize for reading, not writing: in other words, convenience when writing code does not matter in the face of improving the readability of the code.

(Separately, a component that small should be an SFC, not a class-based component, and neither of those two components likely have any performance benefit by being a PureComponent)