Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Sort-comp rule doesn't enforce getDerivedStateFromProps placement

See original GitHub issue

With “react/sort-comp”: “warn” provided code shouldn’t be considered valid:

static getDerivedStateFromProps(nextProps, prevState) {}

state = {}

Tested on version 7.8.2

Issue Analytics

State:
Created 5 years ago
Reactions:2
Comments:9 (9 by maintainers)

Top GitHub Comments

1reaction

ljharbcommented, May 14, 2018

aha, this seems to be a bug in the sort-comp implementation then - since the lifecycle methods are typically instance methods, but getDerivedStateFromProps is a static method.

cc @joe-denea / #1771 which has tests for the “valid” case for this method, but not for the “invalid” case.

0reactions

ljharbcommented, May 15, 2018

Fixed in #1795.

Top Results From Across the Web

Why getDerivedStateFromProps does not allow to re-render ...

When a make an update to the component's state, the state changes (and the component did after updated) but still renders the previous...

eslint-plugin-react | Yarn - Package Manager

List of supported rules ; state-in-constructor, Enforce class component state initialization style ; static-property-placement, Enforces where React component ...

You Probably Don't Need Derived State – React Blog

Anti-pattern: Unconditionally copying props to state A common misconception is that getDerivedStateFromProps and componentWillReceiveProps are ...

eslint-plugin-react @ 7.10.0 .. 7.12.4 - Package Diff

+* add [`jsx-fragments`][] rule to enforce fragment syntax ([#1994][], ... +* [`sort-comp`][]: Fix fixer in case of more than 10 props ([#2012][], ...

React specific linting rules for ESLint - BestofReactjs

react/sort-comp, Enforce component methods order ... Rule `require-default-props` does not support default parameters in stateless function.