sort-comp rule is broken

Hi folks,

First of all thanks for the great work and effort on this.

I’m opening this issue because I believe that the actual order is broken, consider this example:

class App extends PureComponent {
  something = {
    whatever: true,
  };

  state = {
    count: 0,
  };

  constructor(props) {
    super(props);
    this.ws = new WebSocket("ws://localhost:5000/api/1.0/events");
    this.ws.onerror = this.onWsError.bind(this);
    this.ws.onmessage = this.onWsMessage.bind(this);
  }

  componentDidMount() {
    // ...
  }

  render() {
    // ...
  }

  onWsMessage(ev) {
    // ...
  }

  onWsError(ev) {
    // ...
  }

}

Which produces these errors:

something should be placed after onWsError state should be placed after constructor

😟 Mhh… ok, let see:

class App extends PureComponent {

  constructor(props) {
    super(props);
    this.ws = new WebSocket("ws://localhost:5000/api/1.0/events");
    this.ws.onerror = this.onWsError.bind(this);
    this.ws.onmessage = this.onWsMessage.bind(this);
  }

  state = {
    count: 0,
  };

  componentDidMount() {
    // ...
  }

  render() {
    // ...
  }

  onWsMessage(ev) {
    // ...
  }

  onWsError(ev) {
    // ...
  }

  something = {
    whatever: true,
  };

}

😄 I hope you agree with me that it doesn’t make sense… state is included inside the lifecycle category, but something in the everything-else, while in fact both are just public fields which should be both initialised before the constructor IMHO.

That would make sense for you? I could make a PR if you want.

Thanks!

[nuragic]

Ok, I’ll try to make a PR then!

[ljharb]

This rule now has “instance-variables” and “instance-methods” as group options.