sort-comp wrong order with RegExp rules and static methods

I believe this issues comes from #1795

The Airbnb rules for react include sort-comp with regex matching. source here

If you have a static method that matches any of the 3 RegExp values (e.g. renderCell) then this will push to indexes, and the following check for method.static will not happen because of the new conditional on empty indexes.

This should be valid according to the Airbnb Rules.

class Row extends React.Component {
  static getDelta(data) {
    ...
  }

  static onTimeout() {
    ...
  }

  static renderCell(data) {
    ...
  }

  constructor(props) {
    ...
  }

  render() {
    ...
  }
}

[nosilleg]

I’m creating a PR. The fix is a bit more involved than a revert or added RegExp check.

[nosilleg]

I have no doubt that havinggDDFP in lifecycle is a valid view. I’m willing to bet others think having it with statics is preferable. The precedence set with RegExps when this rule was first created is that things can appear in any matching group.

Making it more strict would require going back to your original PR commit and having explicit exceptions to rules. It may be the case that my PR will be a partial revert of your PR in your eyes, since it’s less strict.

Allowing static methods/properties to be in multiple places fixes two additional issues. #1838 and #1808

I’ll push the PR and see what the feedback is. It should be done shortly after adding a test for an undiscovered bug that my changes fix. (While hopefully not breaking things we don’t have tests for.)