question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

rightOuter join will only join to the last table included in the list

See original GitHub issue

Hi, developers! @benmccann @lwhite1

rightOuter join has the same bug with leftOuter join, which is mentioned in #807. Left outer join is easy to fix, while this one will be a little bit difficult.

The problem is related to field joinColumnIndexes. In the right outer join, the join columns in the first table will be removed, then the indexes in this field become invalid. If we continue to joining to next table, an error will show up in function emptyTableFromColumns.

I plan to fix it by recomputing joinColumnIndexes after each join (which is not elegent in some way). OR we can choose to remove the join column in table2 rather than table1 (this will change the order of the column).

I look forward to hearing your thoughts.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
Carl-Rabbitcommented, Apr 30, 2021

OK, I will try to fix rightOuter first. I haven’t found any bugs in fullOuter. I’ll add some tests later and keep an eye on it.

0reactions
lwhite1commented, May 3, 2021

Hi @Carl-Rabbit, Thanks for working on this. Can this issue be closed now?

Read more comments on GitHub >

github_iconTop Results From Across the Web

SQL OUTER JOIN overview and examples
In SQL Full Outer Join, all rows from both the tables are included. If there are any unmatched rows, it shows NULL values...
Read more >
SQL Outer Joins | Intermediate SQL - Mode Analytics
Outer joins are joins that return matched values and unmatched values from either or both tables. There are a few types of outer...
Read more >
Using a LEFT OUTER JOIN vs. RIGHT OUTER JOIN in SQL
Keep in mind that the LEFT OUTER JOIN asks for all rows from the result set or table on the left side of...
Read more >
SQL Full Outer Join - w3resource
The SQL FULL OUTER JOIN will return all rows, as long as there's matching data in one of the tables.
Read more >
SQL Joins Tutorial: Cross Join, Full Outer Join, Inner Join, Left ...
In a right join, all of the rows from the "right" table are returned. The "left" table is conditionally returned based on the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found