question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`redirect_uri` checking is not spec compliant

See original GitHub issue

According to the spec the server must fully match the given redirect_uri.

REQUIRED. Redirection URI to which the response will be sent. This URI MUST exactly match one of the Redirection URI values for the Client pre-registered at the OpenID Provider, with the matching performed as described in Section 6.2.1 of [RFC3986] (Simple String Comparison).

The current implementation strips query parameters. This is non compliant and provides a potential security risk.

I would suggest sticking to the specification, although this leads to backwards incompatible changes for users of this library.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:2
  • Comments:5

github_iconTop GitHub Comments

1reaction
brackicommented, Jul 7, 2017

OK. #191 addresses the issue. Maybe you can take a look at it @wojtek-fliposports.

0reactions
wojtek-fliposportscommented, Jul 7, 2017

Thank You for this great contribution. Merged

Read more comments on GitHub >

github_iconTop Results From Across the Web

Specific redirect URI for each OP · Issue #291
This is a quick test I did with WSO2 IS.. When you send the following authorization request (where the iss value is not...
Read more >
Allowing redirect_uri to be different than the one specified ...
To check this myself I changed the redirect_uri in the dev console to the base domain, and then attempted to set the redirect_uri...
Read more >
Is "Authorized redirect URI" mandatory when setting up a ...
Yes, in Google OAuth 2.0, although you can set no uris in REDIRECT URIS, it doesn't make any sense. Redirect uri is required...
Read more >
Add a redirect URI to a login client
And here's the answer to that question: valid redirect URIs are redirects specified in your OIDC login client. For example, by checking the...
Read more >
Failed Silent Auth - The specified redirect_uri '...' does not ...
I've finished setting up Auth0 on our test site and authentication with various ... Failed Silent Auth - The specified redirect_uri '.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found