Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[🐛] Errors not rendered on "Change Password" form

See original GitHub issue

The only working feedback when submitting the Change Password form is the success notification in this.confirmation. No error message is ever displayed on screen. The corresponding code blocks are reached for the expected error conditions, but the this.error field is never shown on screen.

Issue Analytics

State:
Created 2 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

bkimminichcommented, Jan 2, 2022

Thanks @SakshiUppoor for this fix! If you email or Slack-DM me your address, I’ll send you those promised stickers asap!

1reaction

bkimminichcommented, Jan 2, 2022

Hi! That’s great & highly appreciated! Once your PR is merged please mail me your post address so I can send you our famous „first time contributor sticker pack“! 😊 Cheers, Björn

Von: Sakshi Uppoor @.> Gesendet: Sonntag, 2. Januar 2022 16:52 An: juice-shop/juice-shop @.> Cc: Björn Kimminich @.>; Mention @.> Betreff: Re: [juice-shop/juice-shop] [🐛] Errors not rendered on “Change Password” form (Issue #1733)

Hi @bkimminich https://github.com/bkimminich I would like to work on this issue Will make a PR soon

— Reply to this email directly, view it on GitHub https://github.com/juice-shop/juice-shop/issues/1733#issuecomment-1003735813 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26CDF4OQASHS2FUYC6H5DUUBYAJANCNFSM5IPH3H3A . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AA26CDCQA7CLCZMSOFIKKQDUUBYAJA5CNFSM5IPH3H3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHPJ4WBI.gif Message ID: @.*** @.***> >

Top Results From Across the Web

my change password forms error is not working in my html page

Looks like you are missing 's' at the end of this line {% for error in field.error %} should be ...in field.errors %}...

User Password Reset errors not working properly - Laracasts

Hey! I have a User Reset Password page that lets an authenticated user reset their password by entering the following inputs: *current password, ......

Should password fields be blanked when inline validation fails?

I think the main thing to worry about here is the familiarity of forms blanking the password field on a form validation error....

Error highlighting and reporting problems for the current ...

Problem/Motivation When changing the e-mail and/or password fields on the user profile form without entering a correct 'current password' ...

Working with forms - Django documentation

If an invalid bound form is rendered, it can include inline error messages telling the user what data to correct. The form's is_bound...