Done Counter for Individual Terms

For me it felt like a callback function is missing. The filter feature was quite nice and I was able to use that. Still, it does not feels like the correct way to work with this.

Steps to reproduce

https://github.com/jenstornell/kirby-keyword-map/blob/master/fields/keywordmap/assets/js/src/script.js#L42

'filter': function(textNode, keyword, totalCounter, counter){
	var keyword = keyword.toLowerCase();
	var count = parseInt(counter+1);
	var tag = field.find('.keywordmap-tags [data-tag="' + keyword + '"]');
	tag.addClass('active');
	tag.find('button').html(keyword + '<span class="kwt-count">' + count + '</span>');
	return true;
}

Is there a better way or is this just fine?

If you want to know what it does, this is it:

Environment

• mark.js version 8.8.3

[Mottie]

Hi @jenstornell!

You can use the done callback… I set up this very basic demo that uses it.

$(function() {
  var keywords = ["lorem ipsum", "elitr", "test"],
    context = $(".context").unmark(),
    field = $('.keywordmap-tags').empty();
  keywords.forEach(function(keyword) {
    $(`<span data-tag="${keyword}"></span>`)
      .html("<button type='button'></button>")
      .appendTo(field);
    context.mark(keyword, {
      'separateWordSearch': false,
      'diacritics': false,
      'accuracy': {
        'value': 'exactly',
        'limiters': ['-', '#', ',', '.']
      },
      'done': function(totalMatches) {
        var tag = field.find('[data-tag="' + keyword.toLowerCase() + '"]'),
          html = keyword;
        tag.addClass('active');
        if (totalMatches) {
          html += '<span class="kwt-count">' + totalMatches + '</span>';
        }
        tag.find('button').html(html);
      }
    });
  });
});

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.