Chrome tab not closing properly when using Nodemon
See original GitHub issueI have an issue where restarting my server through Nodemon does not close the tab, but instead renders this error message:
After looking through the source code I think I’ve isolated the problem to here. The catch
for the HTTP request does not consider a valid case where the debug server is not down, but the ID of the debugger websocket changes.
A proposed solution would be to store the unique identifier for each devtools session, and check if that identifier is in the returned JSON from the localhost debug server. Requests coulda also be minimized by making the request only once and filtering $scope.devToolsSessions
according to the returned identifiers.
I’d be willing to PR this in the next couple days with your OK @june07
Edit: Initial conversation about this issue can be found here.
Issue Analytics
- State:
- Created 7 years ago
- Reactions:1
- Comments:10 (7 by maintainers)
Top GitHub Comments
No worries. Glad to help. And thank you for the positive feedback! If it’s not too much trouble, a review and/or rating at the Web Store would help out greatly.
On Dec 25, 2016 11:31 PM, “Darryl Dexter” notifications@github.com wrote:
Sorry, commented before I worked it out. Needed to update chrome apparently… Thx, awesome plugin!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/june07/NIM/issues/1#issuecomment-269176827, or mute the thread https://github.com/notifications/unsubscribe-auth/AK099lT6OEK2n48hjRPQEp_l-l9uecPcks5rL21WgaJpZM4LQFWn .
Are you using the current version? Any additional information you can provide will be helpful in figuring out what is going on. I’m sure you have already but in case not, please read through the entire thread as some information may be helpful.