question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Dependabot triggers sonarqube on forks, commenting on closed issues

See original GitHub issue

Our current sonarqube implementation/usage is a little bit flacky.

There are two issues:

  1. we can not share secrets with forks, thats why we checked in the sonar token within the code (this is still bad, and we need to address this as pointed out by @beatngu13 )
  2. due to this, and the configuration forks will also do sonar analysis and upload the result to the same project. This is bad as it leads to comments on already closed tickets like #5

We do have multiple options regarding this.

  1. we could change the sonar project key to be determined by the Repository name, instead of a hardcoded value. This would allow projects to still analyse the project, if they first create it. But we would not have those comments (i see this as a win). We would need to use the environment variable from GitHub Action (if present), transform it into a valid project key (replace / with _) and we should be good to go.
  2. The secret part is more tricky. As this is not supported by GitHub Action. We could change the process of the sonarqube analysis. so we trigger the analysis by a different user - and just the analysis. As this seems to be a not so trivial task, we might create an own issue to start thinking about a solution. Still this infromation is relevant in here.

This relates to https://github.com/dependabot/dependabot-core/issues/2804 as dependabot and forks, are still a problem, because all of them will receive pull requests if default configuration is applied, and nobody took care about the security

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
aepflicommented, Mar 3, 2021

@beatngu13 done! disabled comments on Sonarcloud

1reaction
Bukamacommented, Jan 3, 2021

#400 shows the configuration for using our own labels is working

Read more comments on GitHub >

github_iconTop Results From Across the Web

Dependabot triggered Actions cant access secrets or use a ...
I think a much better solution to this whole issue would be the following: By default, workflows only ever run for branches and...
Read more >
"You're not authorized to run analysis" and GitHub bots
For example, I use Dependabot in some of my projects. When I receive a PR, the build fails with “You're not authorized to...
Read more >
Dependabot alerts: optional dismissal comment
Dependabot alerts users can now add an optional comment when dismissing an alert. These comments (maximum 280 characters) are viewable in the ...
Read more >
CHANGELOG - GitHub Pages
Closed issues : There is an issue with GeoWave Bootstrap on EMR > 5.17.2 Due to changes with EMR puppet #1769; Issue with...
Read more >
GitHub statistics for 3.6.0 (Sep 15, 2022) - Matplotlib
We closed 202 issues and merged 894 pull requests. The full list can be seen on GitHub. The following 174 authors contributed 4425...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found