Provide pioneer own AssertJ assertions

When checking ExcecutionResults inside a test class for Throwables you have to go through the results and filter them. While doing this, already assertions are made that there are such results. Furthermore to avoid repeated codes some assertions were moved into a method inside the test class and were so hided when only looking at the acutal test case.

We also have some private assertThat... methods in some extension test classes which can be used in other tests so. Moreover there are no good assertThat(results) methods in the default AssertJ API. So in stream the idea came up to provide some own AssertJ assertion methods, to do something like the following.

//   TODO: assertThat(results).hasSingleTestFailedWith(ExtensionConfigurationException.class);
//   TODON'T: result.hasThrowable().isInstanceOf().hasMessage()?
     results.assertTestFailedWithExtensionConfigurationException();

Another one:

PioneerAnnotationUtilsTests:

		private void assertFailedTestHasMessage(ExecutionResults results, String... messages) {
			assertThat(results.numberOfFailedTests()).isEqualTo(1);
			assertThat(results.firstFailuresThrowableMessage()).isEqualTo(String.join(",", messages));
		}

Examples can be seen at this tutorial

[Michael1993]

What I meant was: Are there enough assertions that assert a single test to create a whole different interface for those assertions? You don’t really answer that question in your answer (only tangentially).

Edit of shame: I misunderstood what you meant. Of course we could also have the same interface for multiple tests:

assertThat(results).hasNumberOfTests(2).thatStarted().thatFailed();

Did you mean it like that? If so, you are absolutely right.

[aepfli]

well the initial goal is to use it internally, but what if your code and the usage is so beautiful and intuitive that this might even be used in other junit5 extension for assertions 😃 who knows.