RunListener implementation questions

I am creating a custom RunListener to update a test run on TestRail with the results from an android automation run. I have two questions:

1. How important is to be able to declare the RunListener as thread safe?

I see if it’s not marked with @RunListener.ThreadSafe the listener will be wrapped in the SynchronizedRunListener. AFAIK, AndroidJUnitRunner will run one test at the time, so I think it doesn’t matter.

1. Which is the best way to know if a test passed? The RunListener API doesn’t have a testPassed() (why?) so what I did is the following:

• Create a set of Descriptions on testRunStarted()
• If testFailure() or testAssumptionFailure() are called, add the Description instance to the set
• When testFinished() is called, if the Description instance is not in the set, I mark the test as passed

Thanks for your time!

[marcphilipp]

You know that a test passed when testFinished() is called without a prior call to testFailure() with the same Description.

[sebastianvintila]

@Macarse regarding the issue of missing testSuccess method here is the solution i have implemented

private static final Description FAILED = Description.createTestDescription(“failed”, “failed”);

public void testFinished(Description description) throws Exception { System.out.println("Finished test: " + description.getMethodName()); if (description.getChildren().contains(FAILED)) { // action for test failed } else { // action for test success } }

public void testFailure(Failure failure) throws Exception {
    System.out.println("Failed test: " + failure.getDescription().getMethodName());

// mark the test as being failed failure.getDescription().addChild(FAILED); }