onsave sometimes stops working until I restart VSCode

Hi

I have these configs in my workspace settings:

		"php-cs-fixer.config": "..\\myrepo\\phpcsfixer.php",
		"php-cs-fixer.executablePath": "${workspaceFolder}\\..\\myrepo\\vendor\\bin\\php-cs-fixer.bat",
		"php-cs-fixer.onsave": true,
		"php-cs-fixer.allowRisky": true,

and my phpcsfixer.php:

$config = new PhpCsFixer\Config();
return $config
	->setIndent("\t")
	->setLineEnding("\n")
	->setRules([
(...)
	])
	->setFinder(
		PhpCsFixer\Finder::create()
			->exclude('vendor')
			->in(__DIR__)
	);

Many times, the “onsave” seems to stop working. If I restart VSCode, it works again, but eventually stops working again.

When it works, I can see an output like:

(if there is something to fix)

[
  "fix",
  "--using-cache=no",
  "--format=json",
  "--config=f:\\Files\\Git\\myrepo/..\\myrepo\\phpcsfixer.php",
  "--allow-risky=yes",
  "--path-mode=override",
  "C:\\Users\\myuser\\AppData\\Local\\Temp/myfile.php"
]
{"files":[{"name":"C:\\Users\\myuser\\AppData\\Local\\Temp\\myfile.php"}],"time":{"total":0.104},"memory":14}

(if there is not something to fix)

[
  "fix",
  "--using-cache=no",
  "--format=json",
  "--config=f:\\Files\\Git\\myrepo/..\\myrepo\\phpcsfixer.php",
  "--allow-risky=yes",
  "--path-mode=override",
  "C:\\Users\\myuser\\AppData\\Local\\Temp/myfile.php"
]
{"files":[],"time":{"total":0.079},"memory":14}
Loaded config default from "f:\Files\Git\myrepo/..\myrepo\phpcsfixer.php".
Paths from configuration file have been overridden by paths provided as command arguments.

But when it stops working, there’s no output at all, and the issues stay on the file.

Any ideas why? Or where I can check for any errors.

[junstyle]

open the developer tools, can you see some error logs? please upload next time, otherwise i can’t find the problem.

if you enable "php-cs-fixer.onsave": true, you must make sure "editor.formatOnSave": false first

so i think the best way to format code on save, it enables formattingProvider, settings like these:

"php-cs-fixer.onsave": false,
"php-cs-fixer.documentFormattingProvider": true,
"[php]": {
  "editor.formatOnSave": true,
  "editor.defaultFormatter": "junstyle.php-cs-fixer"
}

you can try

the onsave setting is compatible with early versions.

[bradrogan]

@junstyle same here, it seems things are good with your suggestions. Thanks!