Cmd-Left and Cmd-Right not as expected on MacOS

On MacOS, Cmd-Left and Cmd-Right are supposed to be basically the same as “Home” and “End.”

However, in QtConsole, Cmd-Left has a strange behavior: it literally brings you to the beginning of the line - aka before the prompt. Then, since the cursor is positioned at an “invalid” location, once you type anything it brings you right back to the end of the line.

Adding 8 lines of code to _event_filter_console_keypress(self, event) in console-widget.py yields the correct behavior:

...
    def _event_filter_console_keypress(self, event):
        """ Filter key events for the underlying text widget to create a
            console-like interface.
        """
        intercepted = False
        cursor = self._control.textCursor()
        position = cursor.position()
        key = event.key()
        ctrl_down = self._control_key_down(event.modifiers())
        alt_down = event.modifiers() & QtCore.Qt.AltModifier
        shift_down = event.modifiers() & QtCore.Qt.ShiftModifier

#### BEGIN INSERT
        cmd_down = \
            sys.platform == "darwin" and \
            self._control_key_down(event.modifiers(), include_command=True)
        if cmd_down:
            if key == QtCore.Qt.Key_Left:
                key = QtCore.Qt.Key_Home
            elif key == QtCore.Qt.Key_Right:
                key = QtCore.Qt.Key_End
#### END INSERT
        #------ Special modifier logic -----------------------------------------
...

You could also probably make a _cmd_down_remap similar to the _ctrl_down_remap that you already have, but this seemed simpler.

[battaglia01]

Makes sense. OK, so forgetting that - it seems like the way I’m doing the cmd remapping is alright, so I’ll put these things together in a new PR.

@impact27, your thought about checking the line number is good; I don’t know the easiest way to do that though. Maybe best in a separate issue…

Mike

On Tue, May 4, 2021 at 11:15 PM Carlos Cordoba @.***> wrote:

How does this usually work on Windows, where Ctrl-C equals copy?

Yeah, that’s what it does.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jupyter/qtconsole/issues/483#issuecomment-832385850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHZFMTXXNQWTD2WPU4SCVDTMCZ3JANCNFSM43YZBM2A .

[battaglia01]

OK, PR submitted in #488.