Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Document the soft-deprecated endpoint

See original GitHub issue

https://github.com/yuvipanda/nbresuse/pull/68 switches the main endpoint to /api/metrics/v1, but keeps the original /metrics under a flag.

This should be documented, for example in a new CHANGELOG.md.

Also previous releases of JupyterLab 1.x and 2.x include a status bar item that requests metrics from the deprecated /metrics endpoint. It can be tricky to understand which versions of lab and nbresuse are compatible. However https://github.com/yuvipanda/nbresuse/pull/69 should help with this in the long run.

This is less problematic for classic notebook users since the frontend ships with nbresuse (https://github.com/yuvipanda/nbresuse/pull/69 would do the same for the lab frontend)

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

Gsbreddycommented, Nov 20, 2020

Sure thing. Let me do that and get back to you. On Fri, 20 Nov 2020 at 3:08 PM, Jeremy Tuloup notifications@github.com wrote:

Thanks a lot @Gsbreddy https://github.com/Gsbreddy!

Would you like to open a PR to create CHANGELOG.md with this content?

Also we’ll probably want to:

Sort in descending order

Include 0.3.5 and 0.3.6 too

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yuvipanda/nbresuse/issues/70#issuecomment-731058377, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB26ANN3HTIBARXRWDMV373SQY2HPANCNFSM4T3X737A .