Opening a popup on clicking a GeoJSON object

From the documentation on popup, it seems like popups can only be opened interactively with the marker element.

I wonder if it can also be opened via a custom callback function attached to a GeoJSON.on_click method, adding something like popup.open() or popup.close() to the Popup class.

Seems to be related to #239. Any suggestions on how I should proceed from here?

[martinRenou]

adding something like popup.open() or popup.close() to the Popup class

That sounds like a good idea 😃

If you would like to implement this feature, I guess it will be similar to the redraw function the TileLayer class provides: https://github.com/jupyter-widgets/ipyleaflet/blob/master/ipyleaflet/leaflet.py#L589-L595 It sends a comm message asking for a redraw, and the front-end handles it here: https://github.com/jupyter-widgets/ipyleaflet/blob/3273696bfe73d051fc7864f6731c8ed2198e6f68/js/src/layers/TileLayer.js#L76-L80 Don’t hesitate to ask for more guidance 😃 Opening the popup in JS will look like the following I guess:

this.map_view.el.openPopup(this.el);  // "this.el" is the Popup object at that point

[PROgram52bc]

Any comments on #914?