Button Icons/FontAwesome regression no longer supports fa-spin
See original GitHub issuesince this was added: https://github.com/jupyter-widgets/ipywidgets/blob/master/ipywidgets/widgets/widget_button.py#L65-L73
we are no longer able to pass in additional fa classes to specify fa-spin or fa-lg etc.
I really liked my spinning gear icon button before this change…
i.e.
from ipywidgets import Button
Button(description='Running...', icon='fa-gear fa-spin fa-lg')
it will error on the add of the DOMTokenList due to the spaces in the string https://github.com/jupyter-widgets/ipywidgets/blob/master/packages/controls/src/widget_button.ts#L91
Issue Analytics
- State:
- Created 4 years ago
- Comments:18 (11 by maintainers)
Top Results From Across the Web
Help and Troubleshooting | Font Awesome Docs
Looking for help with Font Awesome on the Desktop? You can find tips and support for desktop issues in Troubleshooting on the Desktop....
Read more >Examples - Font Awesome
You can place Font Awesome icons just about anywhere using the CSS Prefix fa and the icon's name. Font Awesome is designed to...
Read more >fa-refresh: Font Awesome Icons
After you get up and running, you can place Font Awesome icons just about anywhere with the <i> tag: Example of refresh fa-refresh....
Read more >Font Awesome Icons
Spinner Icons. Note: These icons work great with the fa-spin class. Check out the spinning icons example.
Read more >Changelog | Font Awesome Docs
We are no longer missing icons in the thin style of the house-user and ... As always, you can view the official list...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
PR opened https://github.com/jupyter-widgets/ipywidgets/pull/2685
@kebwi Please note that this PR does not add support for multiple icons in a Button. It is only fixing the regression that appeared in 6.0, allowing:
Which I understand is the original issue here. Maybe we could open another issue for multiple icons support?
I’ll try to have a look at this issue tomorrow