CORS is not enabled for BinderHub API

I’d like to use BinderHub’s API to start kernels from another webpage.

When trying to start a notebook server using the BinderHub API, the browser will error because the Access-Control-Allow-Origin HTTP header is missing.

I believe this should be a simple implementation of set_default_headers in the base.py:BaseHandler class but I’m still trying to get binderhub set up locally so I can’t test it myself.

In addition, the current release of notebook (5.1.0) is missing a header that allows starting kernels from another domain. I fixed it in https://github.com/jupyter/notebook/pull/2876 but is there something we can do to get the fix in for the current deployment of Binder?

Happy to talk more about this (in person works too).

Related to #13.

[minrk]

#182 enables CORS on BinderHub itself, with some questions about how exactly we should be doing it.

[SamLau95]

Thanks @minrk! On Mon, Oct 16, 2017 at 5:13 AM Min RK [e-mail] wrote:

@SamLau95 https://github.com/samlau95 CORS should be deployed to beta.mybinder.org now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jupyterhub/binderhub/issues/177#issuecomment-336868194, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWsKAGw06h6Ybwf4lGjNvqvg6eMxJSPks5ss0hagaJpZM4PyFzd .