GenericOAuthenticator doesnt redirect to the Identity server

Hi, I have set up Jupyter Hub on Ubuntu 20.x I have then used tljh-config to set up identity provider as below:

abc@def:~$ sudo tljh-config show
users:
  admin:
  - admin
user_environment:
  default_app: jupyterlab
https:
  enabled: true
  letsencrypt:
    email: [e-mail]
    domains:
    - xx.southeastasia.cloudapp.azure.com
auth:
  GenericOAuthenticator:
    client_id: f120eeee-b3c2-477c-9dd8-725879a5bbd7
    client_secret: xyz
    token_url: https://yy.azurewebsites.net/identity/connect/token
    userdata_url: https://yy.azurewebsites.net/identity/connect/userinfo
    username_key: preferred_username
    login_service: yy
    oauth_callback_url: https://xx.southeastasia.cloudapp.azure.com/hub/oauth_callback
  OAuthenticator:
    client_id: f120eeee-b3c2-477c-9dd8-725879a5bbd7
    client_secret: xyz
  type: oauthenticator.generic.GenericOAuthenticator
os:
  environ[OAUTH2_TOKEN_URL]: https://yy.azurewebsites.net/identity/connect/token
  environ[OAUTH2_USERDATA_URL]: https://yy.azurewebsites.net/identity/connect/userinfo
  environ[OAUTH2_AUTHORIZE_URL]: https://yy.azurewebsites.net/identity/connect/authorize

However, when I try to log in, it gives the following error before even redirecting to my Identity provider:

https://xx.southeastasia.cloudapp.azure.com/hub/oauth_login?response_type=code&redirect_uri=https%3A%2F%xx.southeastasia.cloudapp.azure.com%2Fhub%2Foauth_callback&client_id=f120eeee-b3c2-477c-9dd8-725879a5bbd7&state=eyJzdGF0ZV9pZCI6ICJjYjM5ZjRlNjgzODU0ZDgyOWY0MjVmZDFiN2YwMTBmNyIsICJuZXh0X3VybCI6IG51bGx9

Is there something i have done wrong?

[malichishti]

@consideRatio I managed to solve this eventualy, whats missing in the docs is that if you are using https://oauthenticator.readthedocs.io/en/latest/getting-started.html#general-setup then JupyterHub will be set up as systemmd service. Now the docs does say to define OAUTH2_TOKEN_URL and OAUTH2_AUTHORIZE_URL environment variables but since this is systemd service it has to be done as below:

sudo systemctl stop jupyterhub.service
sudo systemctl edit jupyterhub.service

Add following:

Environment=OAUTH2_TOKEN_URL=https://xx/identity/connect/token Environment=OAUTH2_AUTHORIZE_URL=https://xx/identity/connect/authorize

sudo systemctl start jupyterhub.service

[consideRatio]

For any separate thing that should be a github issue, make it a separate github issue.

I don’t know if the GenericOAuthenticator supports a hybrid auth flow. You can indeed open a feature request for that in this github repo. I have a some wishes as a maintainer trying to find time to do whats needed to maintain this and other repos in this github org:

1. Try to verify it isn’t already a supported feature and reference what makes you think so.
2. Outline clearly the situations where a hybrid flow makes sense for someone to have.
3. If you can, also try summarize technically what needs to be done for GenericOAuthenticator to support this.