github closes stream after token request

When I try to authenticate using GitHubOAuthenticator I always get Exception “Stream closed”. It happens at step 2 of OAuth2 process - “https://github.com/login/oauth/authorize” executes normally and returns code, but when authenticator tries to fetch “https://github.com/login/oauth/access_token?client_id=…” exception is thrown. I found out that it happens in “tornado/simple_httpclient.py” when _write_body method tries to await self.connection.read_response(self).

Although:

1. I tried to fetch other arbitrary URLs from within GitHubOAuthenticator’ authenticate method - it works fine.
2. I tried to fetch GitHub’s token manually with the help of curl - it works fine.
3. I even found and tried to use YandexPassportOAuthenticator which has almost identical code - it works fine!

Does anyone have any ideas why this can happen?

[kpfleming]

Found the solution: the ‘simple’ HTTP client in Tornado doesn’t work for the access_token request which is made to GitHub; configuring Tornado to use curl_httpclient instead (which requires installing pycurl as well) results in successful logins.

Adding these two lines to jupyterhub_config.py will take care of it:

from tornado.httpclient import AsyncHTTPClient
AsyncHTTPClient.configure("tornado.curl_httpclient.CurlAsyncHTTPClient")

[minrk]

Will do. And thanks for finding that curl is a valid workaround! Curl is indeed recommended in production if you have quite a few users, for performance reasons as well.