Hostname in link printed to access the notebook server

Seems like when we switch to notebook 5.5 the link printed in the output will no longer work for people. See for example https://github.com/jupyter/docker-stacks/issues/642

Two questions:

• what is our policy for bumping versions on things like the notebook?
• should we hardcode the --hostname argument to docker in repo2docker to be localhost or 0.0.0.0 or something else entirely?

[betatim]

From https://github.com/jupyter/notebook/pull/3668 it looks like there will be a configuration option for this in notebook in the next release of the notebook.

Currently repo2docker uses notebook v5.4 so we aren’t yet impacted by this. I’d suggest we don’t update the default version of the notebook to v5.5 and wait till https://github.com/jupyter/notebook/pull/3668 has been merged and released. Then go straight for that version with the appropriate configuration set in the default command repo2docker executes.

[AaronWatters]

In that case I’d be in favor of some sort of a solution where the host and port is decided “from the outside” and passed in to the container somehow (env vars?) and those passed in values are printed out when the server reports the connection URL. Sadly, I don’t know the details on how to implement this, but I suspect it should be possible, maybe as some sort of a wrapper to docker run?