question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use vawy line instead of background decoration?

See original GitHub issue

Vawy lines are the default way of highlighting errors in modern text editors. This extension however, uses the vim-like background styling (which is also nice), but might not be intuitive for some users; I find it a little bit distracting and would prefer the red vawy line instead.

I managed to get vawy lines by modifying the styles.css:

Screenshot from 2019-04-21 19-43-23

.CodeMirror .cm-spell-error:not(.cm-url):not(.cm-tag):not(.cm-word) {
     text-decoration-line: underline;
     text-decoration-style: wavy;
     text-decoration-color: red;
     /* For Chrome */
     text-decoration-skip-ink: none;
}

A more browser-independent version could use background images, but the above one is probably more light-weight and performant. Currently the text-decoration styling is supported for 75-89% of users globally (thouh the figure should be higher for people who work with Jupyter as I expect such users to be aware of risks of using outdated browsers).

If I open a PR, would you consider merging it, or are there reasons for keeping the current red background instead?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:4
  • Comments:10

github_iconTop GitHub Comments

3reactions
StevenLi-DScommented, Nov 4, 2019

I think it might be better to increase the alpha of the background color a bit since it is a little bit hard to see while using the dark theme in jupyter lab

Read more comments on GitHub >

github_iconTop Results From Across the Web

Wavy Backgrounds with CSS & SVG - Fireship
The following tutorial demonstrates several different ways to create wavy backgrounds with CSS and SVG.
Read more >
Wavy line background on link hover - css - Stack Overflow
I want this line to be wavy, instead. I've tried text-decoration-style: wavy but it's not supported across browsers and it puts the wavy...
Read more >
text-decoration-color - CSS: Cascading Style Sheets | MDN
The color applies to decorations, such as underlines, overlines, strikethroughs, and wavy lines like those used to mark misspellings, ...
Read more >
How to Create Wavy Shapes & Patterns in CSS
Instead, we will reproduce a wave using the basics of geometry. ... take that line and repeat it. A squiggly red line in...
Read more >
A story on web engines interoperability related to wavy text ...
A simple example is a wavy underline ( text-decoration: wavy green underline ) on a “m” letter using big fonts (see the picture...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found