question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Diff is (sometimes) not updated even after closing and re-opening

See original GitHub issue

Description

After certain sequence of events that I cannot reproduce yet the notebook diff stops updating. The old/partial/incorrect (not sure which) diff is shown instead. No error is shown to the user.

Reproduce

In the diff there are SVG outputs and code cells.

I have not found a way to reproduce this yet. Roughly it could be something like:

  • modify a tracked notebook
  • added to staging area
  • diff
  • close diff
  • modify again
  • diff
  • see the old/partial/incorrect diff
  • see in network requests in developer tools that diffnotebook? correctly downloads the updated diff but it is not being displayed
  • see captured nbdime error:
Failed to init notebook diff view: Error: Invalid arguments to createDirectStringDiffModel(). Both base and remote cannot be equal!

When I tried to diff that notebook using nbdime button directly:

Uncaught (in promise) Error: Invalid arguments to createDirectStringDiffModel(). Both base and remote cannot be equal!
    at Object.t.createDirectStringDiffModel (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at stringify (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at stringify (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at m.createOutputTextView (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at m.createView (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at new m (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at Function.createView (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at h.init (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at new h (568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1)
    at 568.aa5ce6fc20353381fe5b.js?v=aa5ce6fc20353381fe5b:1

Expected behavior

The diff should get updated; if diff cannot get updated to the new one full an error should be shown to the users to that:

  • they are not shown incorrect diff (which is misleading and dangerous)
  • they can report this here with more details so we can solve it

Context

JupyterLab: 3.0.15

  • Python package version: 0.30
  • Git version: 2.31
  • Operating System and its version: Ubuntu 21.04

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
fcollonvalcommented, May 19, 2021

Is there a way to enable source map for extensions easily (without installing the dev version)? It seems to work for core packages.

With federated module, I think the only possibility is to install nbdime in dev mode as maps are not part of the distributed package files.

0reactions
fcollonvalcommented, May 26, 2021

Thanks @vidartf - closing this one.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Browsers does not reflects updates in the code - html
I know this is a very old topic, but Firefox still fails to show code changes after refreshing a page, then viewing the...
Read more >
How do I fix Chrome closing and reopening itself automatically?
If Chrome still crashes, remove all extensions that are not official Google products. 99% chance, this will fix it. Start adding extensions back...
Read more >
Merge requests not updating after branch pushes - GitLab.org
Even after the browser cache is cleared. If the merge request is closed and reopened, the latest commits do appear in the commit...
Read more >
Why Don't Stocks Begin Trading at the Previous Day's Closing ...
These fluctuations are why closing and opening prices are not always identical. ... are happening and shifting the prices of stocks even after-hours....
Read more >
Bug reopen vs. new - Software Engineering Stack Exchange
Characteristics do not equal causes. The new bug could have a different underlying reason, even though it appears to be the same.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found