Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Jlab freezes if incorrect clone url or credentials or already cloned repo url is given

See original GitHub issue

Description

When the user tries to clone a repo that already exists in the base path, the window freezes and no error or status are shown. Same behaviour is seen if the clone url is incorrect, or the credentials entered by the user is incorrect.

Reproduce

Open the jupyter lab with the extension enabled.
Clone a repo in to the home folder
(a)After the clone is finished, try to clone the same repo again (b) In the terminal prompt for entering clone url, enter a invalid one © After entering the correct clone url, in the credential form, enter incorrect username or password
Window freezes with no error in browser console or logs

Expected behavior

Either a dialog box appears saying that the repo already exists or some status that indicates that the operation has failed. Input Validation on the entered values

Context

Python package version: 3.5

Extension version: v0.10.0

Command Line Output

Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.

Browser Output

Paste the output from your browser Javascript console here.

Issue Analytics

State:
Created 4 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

chrisjohn2306commented, Feb 25, 2020

I have a fix for this issue along with the fix for the concern raised in https://github.com/jupyterlab/jupyterlab-git/issues/534 regarding the confusing warning message.

I would like to contribute it to the repository. Is there any T&C formalities to contribute to the repo ?

0reactions

telamoniancommented, Mar 25, 2020

Fixed by #556