question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add back `importhook` for patches

See original GitHub issue

Problem

#250 reverted the use of importhook as it seemed to be causing issues with the recursion limit in Chromium 91 (#248).

Ideally we should try to bring it back

Proposed Solution

We could try to open #239 again, and test against Chromium.

Have some end to end testing (#6) on multiple browsers (firefox and chromium) might also help catch such issues.

Additional context

#239 #248 #250

cc @dsblank

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
jtpiocommented, Jul 22, 2021

There might be some changes in the next Pyodide version regarding the recursion limit: https://github.com/pyodide/pyodide/pull/1733

0reactions
bollwyvlcommented, Mar 18, 2022

Semi-related: at present, we only ship one version of the widgetsnbextension shim package, and install it at startup.

However, on #563, it appears this version is incompatible with the ipywdigets 7.7,0 that just came out:

ValueError: Requested 'widgetsnbextension~=3.6.0', but widgetsnbextension==3.5.0 is already installed

will look into it, as it might be the case that we can just ship multiple versions…

Read more comments on GitHub >

github_iconTop Results From Across the Web

5 Pack Plastic Hook Backing for Patches 4x2 inch - Amazon.com
The fabric has hook backing and is designed to be stuck on the back of an embroidered patch with plastic backing. It will...
Read more >
[20.0.8] import hook assumes existence of `exec_module` but ...
Hello, a fix for this issue has been released via virtualenv 20.0.9; see https://pypi.org/project/virtualenv/20.0.9/ (https://virtualenv.pypa.io ...
Read more >
PEP 302 – New Import Hooks - Python Enhancement Proposals
This PEP proposes to add a new set of import hooks that offer better ... to be loadable from an import hook, the...
Read more >
Monkey-patching: a magic trick or a powerful tool? - YouTube
Elizaveta Shashkova - Monkey- patching : a magic trick or a powerful tool?[EuroPython 2016][22 July 2016][Bilbao, Euskadi, ...
Read more >
Add hook_post_config_import_NAME after config import
Attached a first patch. I chose to call the hook hook_post_config_import_NAME because even though it is part of the update system and works...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found