Improve previews and auto-deploys on Vercel with more control on the build step
See original GitHub issueProblem
At the moment it’s really convenient to be able to open a PR and have the bot post a link to the preview. As well as having JupyterLite automatically be published to https://jupyterlite.vercel.app when the PR is merge into the main
branch.
With https://github.com/jtpio/jupyterlite/pull/57 we however start having a more complex build system that also involves Python dependency management. And adding Python makes the Vercel configuration more complicated (also difficult to get it to work).
Proposed Solution
It would be interesting to start using this action: https://github.com/amondnet/vercel-action.
Looks like we would get everything needed:
- comment on new PRs with a link to the preview
- full control on the build and its dependencies via GitHub Actions workflows
- the app is still pushed to Vercel just like it is no
The other option mentioned in #57 was to deploy to GitHub Pages instead, using something like https://github.com/marketplace/actions/deploy-to-github-pages (not sure it would be easy to have a preview with this approach)
Additional context
Questions mostly coming from the iterations in https://github.com/jtpio/jupyterlite/pull/57.
Issue Analytics
- State:
- Created 2 years ago
- Comments:15 (7 by maintainers)
Top GitHub Comments
Anyhow: if you had some notes on the federated junk, I’m more than happy to start digging into docs/pipes/builds, since I wasn’t making a lot of headway.
Funny story: I demoed running robot framework inside polite today… Pretty insane.
Maybe we can actually remove the Vercel deploy workflow from this repo.
The RTD setup has been working well so far, so we could just document the Vercel case in the docs.